Add canonical URLs to fix duplicate page SEO issue #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Went with `0053` as the canonical vs `53` since David said: "We can decide whether the canonical URL is /rfd/0004 or /rfd/4. Not sure there's any principled way to decide, but the former is what we use on the site index currently." I normally perfer super clean (and short) urls, but I think the zero-padded version does preserve that "RFD 0053" aesthetic that's part of the Oxide RFD culture so I went with that! - Add <link rel="canonical"> tags to RFD pages, index, and login - Redirect non-canonical RFD URLs (/rfd/53) to canonical format (/rfd/0053) - Update internal links to use canonical format (formattedNumber) Fixes oxidecomputer#150
|
@oblakeerickson is attempting to deploy a commit to the Oxide Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I'll add some tests too... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went with
0053as the canonical vs53since David said:"We can decide whether the canonical URL is /rfd/0004 or /rfd/4. Not sure there's any principled way to decide, but the former is what we use on the site index currently."
I normally perfer super clean (and short) urls, but I think the zero-padded version does preserve that "RFD 0053" aesthetic that's part of the Oxide RFD culture so I went with that!
Fixes #150