Add new toggle theme button for logged-out and logged-in users. #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change users don't have to be logged in to change the theme if they desire. I do really like the dark theme, but now we can give anonymous users the option to choose the light theme without having to log in. Resolves oxidecomputer#176
|
@oblakeerickson is attempting to deploy a commit to the Oxide Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I think for follow up we should toggle the icon too so we have a light icon and a dark icon. Instead of just using the same icon. Also for follow up I'm making a PR for issue #172 that depends on this PR. I found that issue after making this PR. |
oblakeerickson
added a commit
to oblakeerickson/rfd-site
that referenced
this pull request
Dec 11, 2025
Rather than defaulting to the dark theme, let's default to the user's system setting so that the light or dark theme is selected automatically. If there is no cookie present for the theme selection default to the system theme. If there is a cookie set use that regardless of system theme. Regarding the code, we are using reacts `dangerouslySetInnerHTML` property https://react.dev/reference/react-dom/components/common#dangerously-setting-the-inner-html but we are using it in a safe way. It only interpolates `theme` which is `'light'`, `'dark'`, or `null` - values we control from the cookie. Even if someone tampered with the cookie, the only values that matter are `'light'` or `'dark'`. Anything else just defaults to dark mode. So its safe to use in this case. Resolves oxidecomputer#172 Depends on oxidecomputer#177
Author
|
Okay I made my follow up PR: oblakeerickson#1 for #172 I made it a separate PR as to not complicate this PR as I'm still awaiting feedback. If all is well and it gets merged I'll re-point that PR to this org for feedback (the theme-toggle branch doesn't exist in the oxidecomputer rfd-site repo). |
Author
|
Just pushed a follow up commit to add sun and moon icons.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change users don't have to be logged in to change the theme if they desire.
I do really like the dark theme, but now we can give anonymous users the option to choose the light theme without having to log in.
Resolves #176