New RFD form modal #165
Open
New RFD form modal #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@augustuswm when you get a moment, can we test this against a non-prod API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses new RFD post endpoint to create a new RFD. This endpoint may be successful, but it takes time to be both added to the GitHub repo and then scanned and collected by the database. To this end, this modal creates an RFD then polls to see if it has been created yet (see fetchWithRetry).
Currently it does not populate authors, waiting on an update to the endpoint to take authors and labels fields. The idea being it uses the authors email and name from the logged in user. The email returned from GitHub might not be an Oxide one, so we should attempt to find an Oxide email and if that can't be done it should just stay undefined.
Userto store the array of emails returned from the auth providerMove text input component into the design systemReapplication of #65