Remove abandoned RFDs from index #149
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
I think this is probably fine for now. Longer term we could probably add state filters and have it filter out abandoned by default. Search I am unsure about, is there a situation where someone might want to search including abandoned RFDs? |
Contributor
Author
|
Yeah, the more I think about it, I think we should hold this until we implement it as a filter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recommendation from @bcantrill that we should de-emphasis abandoned RFDs. Effectively we have decided that we are not committing to the contents, and may be misleading.
From RFD 1:
This change removes them from the index list. We need some backend changes to remove them from search.
This does not delete data, or break direct links. We should also add a warning at the top of abandoned RFDs to re-enforce that they are no longer applicable.