update usdt to 0.6.0 #995
Open
update usdt to 0.6.0 #995
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dropshot includes usdt probes and as of 0.16.6 depends on usdt 0.6.0 to do so. this introduces a few duplicate-ish dependencies that feel a bit unsightly. in particular, usdt 0.5.0 -> 0.6.0 comes with a few major version bumps of usdt dependencies so they can't simply be unified to a common latest version. bumping Propolis is not sufficient to dedupe these dependencies, as we get them from Crucible, Oximeter, `qorb`, `slog-dtrace`, and `tokio-dtrace`, as well as `usdt 0.3.5` from `p4rs`. but getting Propolis ahead of things means once they're all bumped and bumped here, we'll lose deps on `goblin 0.8.2`, `scroll 0.12.0`, `dof 0.3.0`, and probably a few others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dropshot includes usdt probes and as of 0.16.6 depends on usdt 0.6.0 to do so. this introduces a few duplicate-ish dependencies that feel a bit unsightly. in particular, usdt 0.5.0 -> 0.6.0 comes with a few major version bumps of usdt dependencies so they can't simply be unified to a common latest version.
bumping Propolis is not sufficient to dedupe these dependencies, as we get them from Crucible, Oximeter,
qorb,slog-dtrace, andtokio-dtrace, as well asusdt 0.3.5fromp4rs. but getting Propolis ahead of things means once they're all bumped and bumped here, we'll lose deps ongoblin 0.8.2,scroll 0.12.0,dof 0.3.0, and probably a few others.edit: one (me!) may ask if usdt 0.6.0 gets Propolis anything interesting, and the most I see is the (neat!) stap v3 probe support but since Propolis is so very illumos-only maybe that's not important here :)