Skip to content

bump to poptrie with 8-byte aligned keys #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rcgoodfellow wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump to poptrie with 8-byte aligned keys #902

rcgoodfellow wants to merge 1 commit into from

Conversation

@rcgoodfellow
Copy link
Contributor

@rcgoodfellow rcgoodfellow commented Dec 19, 2025 •
edited
Loading

@rcgoodfellow rcgoodfellow added this to the 18 milestone Dec 19, 2025
@rcgoodfellow rcgoodfellow linked an issue Dec 19, 2025 that may be closed by this pull request
Setting Virt-to-Boundary mappings for IPv6 inner addresses kernel panics due to alignment constraints #901
Open
@rcgoodfellow rcgoodfellow marked this pull request as ready for review December 19, 2025 07:54
@rcgoodfellow
Copy link
Contributor Author

rcgoodfellow commented Dec 19, 2025

Took this for a spin in a4x2, tunnel routing still working and no crashes on sync of v6 routes to v2b

root@g0:~# ./opteadm dump-v2b
Virtual to Boundary Mappings
======================================================================

IPv4 mappings
----------------------------------------------------------------------
TUNNELED PREFIX  BOUNDARY IP             VNI
0.0.0.0/0        fdb1:c4dc:978c:54af::1  99
0.0.0.0/0        fddf:dd88:4ccd:6bbe::1  99

IPv6 mappings
----------------------------------------------------------------------
TUNNELED PREFIX  BOUNDARY IP             VNI
fdfd::/56        fddf:dd88:4ccd:6bbe::1  99

FelixMcFelix
FelixMcFelix approved these changes Dec 19, 2025
View reviewed changes
Copy link
Collaborator

@FelixMcFelix FelixMcFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see on Matrix that everything works now!

Cargo.toml
Comment on lines +83 to +84
poptrie = { git = "https://github.com/oxidecomputer/poptrie", branch = "ry/8-byte-key-alignment" }
#poptrie = { git = "https://github.com/oxidecomputer/poptrie", branch = "main" }
Copy link
Collaborator

@FelixMcFelix FelixMcFelix Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a reminder to unset this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FelixMcFelix FelixMcFelix FelixMcFelix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18

Development

Successfully merging this pull request may close these issues.

Setting Virt-to-Boundary mappings for IPv6 inner addresses kernel panics due to alignment constraints

3 participants

@rcgoodfellow @FelixMcFelix