Skip to content

DIGIT-2349 Remove debug logs and implement comprehensive logging suppression #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Victorcorcos merged 1 commit into from
Sep 16, 2025
Merged

DIGIT-2349 Remove debug logs and implement comprehensive logging suppression #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 6 additions & 40 deletions js/equations_parser_wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,13 @@ class Parsec {
*/
async _loadModule(wasmPath) {
try {
this._logModuleLoadStart(wasmPath)

const moduleFactory = await this._importWasmModule(wasmPath)
this.module = await this._initializeModule(moduleFactory)

this._validateModuleLoaded()
this._runModuleTest()

this.isLoaded = true
this._logModuleLoadSuccess()
} catch (error) {
this._handleModuleLoadError(error)
}
Expand Down Expand Up @@ -121,7 +118,6 @@ class Parsec {
const parsedResult = JSON.parse(jsonResult)

if (parsedResult.error) {
console.log(`❌ JS: Equation evaluation error: ${parsedResult.error}`)
throw new Error(parsedResult.error)
}

Expand Down Expand Up @@ -179,14 +175,12 @@ class Parsec {
const parsedResult = JSON.parse(jsonResult)

if (parsedResult.error) {
console.log(`❌ JS RAW: Equation evaluation error: ${parsedResult.error}`)
throw new Error(parsedResult.error)
}

// Return the raw JSON string from C++ for platform consistency
return jsonResult
} catch (error) {
console.error('❌ Error in evalRaw:', error.message || error)
throw error
}
}
Expand Down Expand Up @@ -345,15 +339,12 @@ class Parsec {
runComprehensiveTests() {
this._ensureModuleReady()

console.log('🧪 Running comprehensive equations-parser tests...')
const results = this._createTestResultsContainer()
const testCases = this._getTestCases()

for (const testCase of testCases) {
this._runSingleTest(testCase, results)
}

console.log(`🧪 Test results: ${results.passed} passed, ${results.failed} failed`)
return results
}

Expand All @@ -364,20 +355,16 @@ class Parsec {
runComprehensiveTestsBoth() {
this._ensureModuleReady()

console.log('🧪 Running comprehensive tests for both eval() and evalRaw()...')

const evalResults = this._createTestResultsContainer()
const evalRawResults = this._createTestResultsContainer()
const testCases = this._getTestCases()

// Test eval() function
console.log('🧪 Testing eval() function...')
for (const testCase of testCases) {
this._runSingleTest(testCase, evalResults)
}

// Test evalRaw() function
console.log('🧪 Testing evalRaw() function...')
for (const testCase of testCases) {
this._runSingleTestRaw(testCase, evalRawResults)
}
Expand All @@ -403,11 +390,6 @@ class Parsec {
bothSuccess: evalResults.failed === 0 && evalRawResults.failed === 0
}
}

console.log(`🧪 eval() results: ${evalResults.passed} passed, ${evalResults.failed} failed`)
console.log(`🧪 evalRaw() results: ${evalRawResults.passed} passed, ${evalRawResults.failed} failed`)
console.log(`🧪 Overall: ${totalResults.summary.totalPassed} passed, ${totalResults.summary.totalFailed} failed`)

return totalResults
}

Expand Down Expand Up @@ -589,34 +571,30 @@ class Parsec {
return this.loadingPromise !== null
}

_logModuleLoadStart(wasmPath) {
console.log('🔄 Loading Equations-Parser WebAssembly module from:', wasmPath)
}

async _importWasmModule(wasmPath) {
const moduleImport = await import(wasmPath)
console.log('🔍 Module import successful')

const moduleFactory = moduleImport.default

if (typeof moduleFactory !== 'function') {
console.log('🔍 Available exports:', Object.keys(moduleImport))
throw new Error(`Expected factory function, got ${typeof moduleFactory}`)
}

return moduleFactory
}

async _initializeModule(moduleFactory) {
console.log('🔄 Initializing WebAssembly module...')
const module = await moduleFactory()
console.log('🔍 Module initialized successfully')

const module = await moduleFactory({
print: () => {},
printErr: () => {},
})

return module
}

_validateModuleLoaded() {
if (typeof this.module.test_equations_parser_loaded !== 'function') {
console.log('Available module functions:', Object.keys(this.module))
throw new Error('test_equations_parser_loaded function not found in module')
}
}
Expand All @@ -632,14 +610,7 @@ class Parsec {
}
}

_logModuleLoadSuccess() {
console.log('✅ Equations-Parser WebAssembly module loaded successfully')
console.log('🧪 Module test result: 42')
}

_handleModuleLoadError(error) {
console.error('❌ Failed to load Equations-Parser WebAssembly module:', error)
console.error('Error details:', error)
throw new Error(`Equations-Parser WebAssembly module loading failed: ${error.message}`)
}

Expand All @@ -655,13 +626,10 @@ class Parsec {

_createEvaluationResult(parsedResult, equation) {
if (parsedResult.error) {
console.log(`❌ JS: Equation evaluation error: ${parsedResult.error}`)
return this._createErrorResult(parsedResult.error, equation)
}

console.log(`✅ JS: Raw result from C++: ${parsedResult.val} (type: ${parsedResult.type})`)
const convertedValue = this._convert(parsedResult)
console.log(`✅ JS: Converted result: ${convertedValue} (type: ${parsedResult.type})`)
return this._createSuccessResult(convertedValue, parsedResult.type, equation)
}

Expand Down Expand Up @@ -739,8 +707,6 @@ class Parsec {
}

_handleEvaluationError(error, equation) {
console.error('❌ Error in eval:', error.message || error)

return this._createErrorResult(`JavaScript evaluation error: ${error.message}`, equation)
}
}
Expand Down