Skip to content

Conversation

@liam923
Copy link
Contributor

@liam923 liam923 commented Feb 3, 2026

This PR addresses a minor bug in the kind hover implementation. Before this PR, as verbosity increases, Merlin would sometimes show the same kind twice. For example, when printing value mod portable, it gives:

Verbosity 0: value mod portable
Verbosity 1: value mod portable
Verbosity 2: value mod portable internal non_null separable

This creates an issue for the LSP, which only displays an option to the user to increase verbosity if the next verbosity level is different from the current level. In the case of value mod portable, this means there's no way to expand the kind beyond value mod portable. This PR fixes that.

Copy link
Contributor

@dkalinichenko-js dkalinichenko-js left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels hacky, but I guess we just have to do what the LSP wants in this case.

@dkalinichenko-js dkalinichenko-js merged commit 3f451fb into main Feb 4, 2026
1 check passed
@liam923 liam923 deleted the kind-verbosity branch February 4, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants