Add mode_enclosing query #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam923
force-pushed
the
merge-5.2.0minus-27
branch
from
f36de89 to
b39d06d
Compare
dkalinichenko-js
approved these changes
Jan 28, 2026
Lucccyo
pushed a commit
to Lucccyo/oxmerlin
that referenced
this pull request
Feb 10, 2026
* Add mode-enclosing * Remove duplicate test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
mode-enclosingcommand to Merlin, which is a mode analogue oftype-enclosing(the command responsible for type hovers). For now, this only displays the mode when hovering on a variable binding or usage. Although this is somewhat limiting, I wanted to keep the scope limited to get this done quickly. I still expect this feature to be very useful.Note: This PR targets a branch that mints a Merlin for a new compiler version rather than the main branch, as it relies on some recent compiler changes. This PR shouldn't be released until that branch gets merged into main.