Use dialog element to manage focus inside modals#91
Open
sivakusayan wants to merge 1 commit intooxalorg:mainfrom
Open
Use dialog element to manage focus inside modals#91sivakusayan wants to merge 1 commit intooxalorg:mainfrom
sivakusayan wants to merge 1 commit intooxalorg:mainfrom
Conversation
Collaborator
|
@oxalorg ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close #89. We're going to rely on the browsers' implementation of the
<dialog>element instead of trying to do our own focus handling. There is still the issue of the dialog's close "X" button not having a focus outline, but that's pre-existing and can perhaps be resolved in a separate PR (mostly because I'm not sure if ya'll have any strong opinions on what the focus outline should look like).As an aside, this is the first time I'm writing any Clojure code at all that isn't just copy-pasting code into a REPL from some book, so don't be shy about feedback 🙂