Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
So whole this file can be removed
Expected failures disappeared after upgrading curl to version that handles chunked upload body with no trailing bytes issues.
There was a problem hiding this comment.
If the errors are intentional and now different i.e. errors codes appear but are not cathced by assert a change in tests is needed.
| */ | ||
| public function theDownloadedPreviewContentShouldMatchWithFixturesPreviewContentFor(string $filename): void { | ||
| $expectedPreview = \file_get_contents(__DIR__ . "/../fixtures/" . $filename); | ||
| $fixturePath = __DIR__ . "/../fixtures/" . $filename; |
There was a problem hiding this comment.
Before, the preview images ~32x17px were compared by exact bytes and apparently different compilations of libjpg (ubuntu, alpine, ...) produced slight differences at per pixel values.
Moving to comparison with threshold solved the issue. Added diagnostic logs to detect what fails and why. Also to see if we do per pixel php comparison on images with not too big resolution.
mklos-kw
force-pushed
the
feat/ocisdev-744-7
branch
6 times, most recently
from
9f6f50c to
18a5cea
Compare
mklos-kw
changed the title
mklos-kw
force-pushed
the
feat/ocisdev-744-7
branch
from
18a5cea to
39a0084
Compare
2 participants
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: