Cannot fetch a user specific theme for various reasons#37
Cannot fetch a user specific theme for various reasons#37butonic wants to merge 1 commit intoowncloud:masterfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Complexity increasing per file
==============================
- pkg/service/v0/service.go 2
See the complete overview on Codacy |
|
IMHO it doesn't make sense to change the config json based on being logged in. |
|
Where is this requirement coming from? We had long req analysis phases on what theming should do. User based theming was never mentioned. |
|
I agree that config.json should not contain user specific configuration. While user individual themes are out of scope for now we want to use the accounts service to determine which apps to load for a user. Not all users will be granted access to all applications, eg. to allow premium accounts or A/B testing of different versions of external apps. I used themes to provide a more simple example. AFAICT the correct enhancement is to read the list of enabled apps from the Does that make more sense? |
|
It makes sense to retrieve the list of allowed apps from some api endpoint, but not from the config json of Phoenix. |
I wanted to use the account service to dynamically adjist the theme, based on who is logged in.
This PR serves to document several problems we should discuss on how to address them:
The way I set up the micro client to look up the accounts service and make a call to fetch the account Record serves as an example. It should be refactored into a separate func of course. In any case I'll put this here for others to learn.