-
Notifications
You must be signed in to change notification settings - Fork 3
implement initial drop logic #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropLib.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropLib.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropLib.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropLib.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropLib.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropLib.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropLib.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropSinglePhaseFacet.sol
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropSinglePhaseFacet.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/ERC721DropSinglePhaseFacet.sol
Outdated
Show resolved
Hide resolved
packages/contracts-diamond/contracts/assets/ERC721/IERC721DropSinglePhase.sol
Outdated
Show resolved
Hide resolved
leovigna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix CI but then good to go.
|
Run |
…heckMaxClaimForAccount
6f57cb4 to
bbc0d34
Compare
|
Currently the ERC721DropLib makes good re-use of the First, we refactor the struct ClaimCondition {
uint256 startTimestamp;
uint256 endTimestamp;
uint256 maxClaimableSupply;
//uint256 supplyClaimed; //REMOVE THIS
uint256 quantityLimitPerWallet;
uint256 pricePerToken;
address currency;
}
//Used by ERC721ClaimLib
struct ClaimConditionState {
uint256 supplyClaimed;
mapping(address => uint256)) accountClaims; //formerly "walletClaims"
}
struct ERC721ClaimStorage {
mapping(bytes32 => ClaimCondition) claimConditions;
mapping(bytes32 => ClaimConditionState) claimConditionStates;
}
///...Update read/write logic accordingly in ERC721Claim LibThe struct DropCondition {
bytes32 merkleRoot;
//mapping(address => uint256) accountClaims; //REMOVE THIS
}
struct DropConditionSate {
mapping(address => uint256) accountClaims; //track account claims and update accodingly
} |
No description provided.