Add NPC Generator

[Jimpeccable]

Make sure that your submission has the following:

• A link to the raw github markdown file with a YAML front matter definition containing:
  • The title of your extension
  • A description of your extension
  • The author
  • A hero image
  • An icon
  • Tags (these will help with your extension's discoverability)
  • A link to your extensions manifest

Please, go through these steps before you submit a PR.

• You have done your changes in a separate branch.

• You have a descriptive commit message with a short title (first line).

• You have only one commit (if not, squash them into one commit).

• Your pull request MUST target the main branch on this repository.

• Your pull request puts your extensions details as the last entry in the extensions.json file

[Jimpeccable]

Been editing the main by accident and usure if reflect here - if so - will resubmit with 1 squashed version over the weekend

[Jimpeccable]

Should all be updated now

[Jimpeccable]

Hi guys - appreciate you're busy - think this is all up-to-date... I'll respond pretty rapidly otherwise 👍

[Several-Record7234]

Hi James,

I've just run the verification script and it threw an error with your use of tags (because we don't currently have either 'roleplay' or 'character' options in the list of supported tags).

Can you remove those please? Otherwise, it looks ready to pass that verification step, then on to Nicola...

[Jimpeccable]

Awesome... Thank you! Get that sorted in the morning 🙌

[Jimpeccable]

All sorted ;-)

[Several-Record7234]

Validation script and image URLs check out fine. Extension functionality and API usage not checked.

[nthouliss]

Only one minor change which would be to lessen the logs in the dev console. Clicking generate a few times pollutes the console a little. You also need to squash your commits.

Just as general feedback (not a requirement for submission):

• There's a lot of scrolling involved to get to the what you're supposed to use the extension for. I don't think you need the DnD Realm Creator text when you already have a logo. I would probably remove the huge stack of buttons and change it to something like a selection drop-down, it would reduce the vertical space a lot. You probably don't need the Patreon QR code at the bottom all the time. You could put this under your Patreon selection (or just have a link to the Patreon under this section instead of a QR code).

I've also noticed that your store page mentions the version (i.e. NPC-Generator-OBR-1.0.4), do you want to do this? You'd have to resubmit if you're tying the store page to a version

[Jimpeccable]

Hey Nicola...

Great, will definitely make those changes!
As for the version number... Hadn't thought.... Can easy change that.

Got super lazy with it being 1 file... The updates I am gonna 💯 change.

Thank you so much by the way guys, really appreciate it!! 🎉 🙌

James 🙌

[nthouliss]

@Jimpeccable it's been a while since changes were requested. If you want to proceed please make those changes or get back to us with any questions. I'll close this PR if I don't hear back from you in a month's time.

[Jimpeccable]

Apologies for the long delay - life got in the way! Here you go, removed buttons in-place of a dropdown ;-)

FEAT: Add NPC Realm Generator to extension list

[nthouliss]

Thanks @Jimpeccable I'll get to this in the next round of releases 😄

[nthouliss]

@Jimpeccable Thanks for updating all that, it's a lot easier to navigate the app now.

I can generate characters and locations just fine but it's really difficult to view these after that are generated (as seen in the saved section). I can see that they're loaded from local storage but I think it would be a more usable experience to be able to see the NPC in the NPC Trust section. If you still want to keep trust Patreon only, I would hide that within the NPC info and change the NPC Trust section to just an NPC section. I would probably do something similar for locations. You may not even need a Saved Items section if you do those changes (you could manage and delete NPCs and Locations from their respective tabs).

If the intention is for the user to just generate the NPC and then save the NPC somewhere else then I would make it really easy to copy the NPC info. As it stands I'm not sure if I would be using this extension for one-and-done things or to generate and keep as a reference, it could be used as either it's just that it doesn't seem to fit into either role fully atm.

I also noticed that you've commited your node_modules to your github, I'd delete those and add a .gitignore to prevent your node_modules folder being commited (otherwise you're making the repo really big and you'll get merge conflicts a lot more).

[nthouliss]

@Jimpeccable could you please update this PR with the latest changes from this extensions repo? The extension needs to be the last entry in the list.