Open
Conversation
Author
|
I would like to include video, would that webm image in my current store.md work? |
Collaborator
|
Validation script and image URLs check out fine. Extension loads OK, no dev console warnings/errors, but functionality and API usage not checked. |
Collaborator
@mvoncken I believe so, but now that I've tagged Nicola in, she can confirm! |
Author
I changed it from video to gif, ready for final review, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that your submission has the following:
Please, go through these steps before you submit a PR.
You have done your changes in a separate branch.
You have a descriptive commit message with a short title (first line).
You have only one commit (if not, squash them into one commit).
Your pull request MUST target the
mainbranch on this repository.Your pull request puts your extensions details as the last entry in the extensions.json file