Skip to content

feat: add Oath Hammer extension#117

Open
sarahtulkki wants to merge 2 commits intoowlbear-rodeo:mainfrom
sarahtulkki:main
Open

feat: add Oath Hammer extension#117
sarahtulkki wants to merge 2 commits intoowlbear-rodeo:mainfrom
sarahtulkki:main

Conversation

@sarahtulkki
Copy link

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@Several-Record7234
Copy link
Collaborator

Hi @sarahtulkki,

Thanks for submitting your extension for publication.

I've just run the first-stage verification and it has failed on a few points:

  1. tags: You may only use our [supported tags](https://github.com/owlbear-rodeo/extensions/blob/main/tags.json) and only extensions published by Owlbear Rodeo can use the built-by-owlbear tag, so I'd suggest you just choose the 'tool' tag for it.
  2. your learn-more link: https://github.com/sarahtulkki/oath-hammer-character-sheet is failing with a 404 error (because your Github is set to be private?)
  3. your manifest.json: the description field is longer than 128 characters, so it is being rejected by the Extension Manager (when I try to add the extension to my OBR account), please shorten this to within spec.

Apart from those things, the rest of the verification completed OK, and the links to your hero and icon images are fine.

Let me know when you've corrected the issues above and I'll re-run the checks again, thanks!

@sarahtulkki
Copy link
Author

sarahtulkki commented Dec 29, 2025

Hello @Several-Record7234 ! Sorry for the delay. The changes have been made and pushed up. Please review when time permits and let me know if you need anything else. Cheers!

@sarahtulkki
Copy link
Author

Hello @Several-Record7234 ! Just poking to see if this is good to go or if it needs more changes. Thanks!

@Several-Record7234
Copy link
Collaborator

Hello @Several-Record7234 ! Just poking to see if this is good to go or if it needs more changes. Thanks!

Just getting back into it after the holidays, I'll run verification again for you now and will update! 😄

@Several-Record7234
Copy link
Collaborator

All seems good, but the extension's icon isn't being picked up when installed as a custom extension. Not sure why, maybe that will fix itself when its published in the store... 🤔
image

@Several-Record7234
Copy link
Collaborator

Hmm, the extension's Action icon doesn't load in the top-left corner of the Room either:
image

Inspecting that button shows that it's trying to load an image from https://raw.githubusercontent.com/icon.svg, which gives a 400 error, can you take another look at that please?

@Several-Record7234
Copy link
Collaborator

Plus the extension's code won't load from Github:
image
image

@Several-Record7234
Copy link
Collaborator

I'm not a developer, but these might be simple issues that you can resolve on your own, or by asking for help in our Discord's developer-chat channel, which is available once you've given yourself the 'Extension Developer' role from the roles channel there 👍

@Several-Record7234
Copy link
Collaborator

So, to confirm, the manifest validation checks out now, but there are still some issues loading the extension data from your hosting server (see https://docs.owlbear.rodeo/extensions/tutorial-sharing-your-extension/hosting-your-extension for details).

@sarahtulkki
Copy link
Author

@Several-Record7234 So sorry about that! I fixed the headers settings on my render environment to ensure it allows iframing by Owl Bear, so it should load now without issues. I also fixed the logo url...it was pointed to an old file, and I have it updated now to point to the right url. Apologies for that!

@Several-Record7234
Copy link
Collaborator

@Several-Record7234 So sorry about that! I fixed the headers settings on my render environment to ensure it allows iframing by Owl Bear, so it should load now without issues. I also fixed the logo url...it was pointed to an old file, and I have it updated now to point to the right url. Apologies for that!

Thank you, it has passed its 1st-stage verification now! Unfortunately there are still some issues, but hopefully they'll be easy to fix!

  1. The manifest.js is still loading v1.0.0 code for me (not sure if this is the newer version that you updated?)
  2. This version is now loading the Action icon, but I think it is converting all of the opaque pixels to white, leaving a plain circle - I don't remember the developer guidance for the Action icon, but if you were to remove the red part and just leave the white sword and book surrounded by transparency, then it would work as a light-on-dark monochrome logo in the Action bar...
  3. It's still giving the 'github.com refused to connect' error when I open the Action popover 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants