Merged
Conversation
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Member
Author
|
Getting one warning for dosai, which apparently is expected for such a DLL. |
prabhu
commented
Nov 13, 2025
| /// <summary> | ||
| /// An enhanced AssemblyLoadContext that resolves dependencies from a list of specified search paths. | ||
| /// </summary> | ||
| internal class InspectionAssemblyLoadContext(IEnumerable<string> searchPaths) : AssemblyLoadContext(isCollectible: true) |
Member
Author
There was a problem hiding this comment.
This way, we can support multiple .NET versions, including shared runtime.
prabhu
commented
Nov 13, 2025
| public List<string> GetNames() | ||
| { | ||
| return new List<string> { "Alice", "Bob" }; | ||
| return ["Alice", "Bob"]; |
prabhu
commented
Nov 13, 2025
| var actualMethods = methodsSlice?.Methods; | ||
|
|
||
| Assert.Equal(32, actualMethods?.Count); | ||
| Assert.Equal(36, actualMethods?.Count); |
Member
Author
There was a problem hiding this comment.
More methods are collected now.
prabhu
commented
Nov 13, 2025
| var failedAssemblies = new List<string>(); | ||
| foreach(var assemblyFilePath in assembliesToInspect) | ||
| var processedAssemblyIdentities = new HashSet<string>(); | ||
| var sharedRuntimePaths = GetDotnetSharedRuntimePaths(); |
Member
Author
There was a problem hiding this comment.
We look for .dll files in more places, such as shared runtime paths.
prabhu
commented
Nov 13, 2025
|
|
||
| return assemblyMethods; | ||
|
|
||
| Method CreateMethodObjectFromMember( |
Member
Author
There was a problem hiding this comment.
This is a cool refactoring suggested by Gemini.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to .net 10. Refactor to use latest C# features. Reviewed with Gemini 2.5 Pro.