Skip to content

improve signature match#30

Merged
prabhu merged 2 commits intomainfrom
feature/improve-signature-match
Sep 12, 2025
Merged

improve signature match#30
prabhu merged 2 commits intomainfrom
feature/improve-signature-match

Conversation

@prabhu
Copy link
Member

@prabhu prabhu commented Sep 12, 2025

Broaden's the source-assembly signature match with a simple fallback to only use the full name without arguments and return types.

assemblyNameLookup.TryAdd($"{asmMethod.Namespace}.{asmMethod.ClassName}.{asmMethod.Name}", asmMethod);
var isMapped = assemblyMemberLookup.TryGetValue(sourceMethod.SourceSignature, out var asmMemberObj);
if (!isMapped)
{
    isMapped = assemblyNameLookup.TryGetValue($"{sourceMethod.Namespace}.{sourceMethod.ClassName}.{sourceMethod.Name}", out var asmMember);
    if (isMapped)
    {
        asmMemberObj = asmMember;
    }
}

To further improve the matching of getters and setter properties { get; set; }, we manually create the equivalent get_ and set_ methods in CreateMethodFromSymbol.

For dotnet-podcasts, we now match 328 methods!

dosai.json.zip

Fixes #29

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu merged commit 4e0e61d into main Sep 12, 2025
2 checks passed
@prabhu prabhu deleted the feature/improve-signature-match branch September 12, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broaden the assemblyMemberLookup

1 participant