Conversation
falkenhawk
reviewed
Feb 2, 2024
.github/workflows/ci.yml
Outdated
| timeout-minutes: 15 | ||
| strategy: | ||
| matrix: | ||
| php: [ '8.0', '8.1', '8.2', '8.3' ] |
Member
There was a problem hiding this comment.
try adding os: [ubuntu-latest, windows-latest] to the matrix, instead of duplicating all steps for windows
Member
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
@falkenhawk thanks, the initial division was in case the setup of PHP for windows is different, but it turned out to be the same so you are right :)
marcing
force-pushed
the
feature/gha-windows
branch
from
7ca309f to
62282ac
Compare
…, bumped actions to v4 to avoid warnings
marcing
force-pushed
the
feature/gha-windows
branch
from
c662c78 to
8d837a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.