Skip to content

#234 - Navbar Link Component #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SaqAsh wants to merge 25 commits into
base: main
Choose a base branch
from
Open

#234 - Navbar Link Component #252

SaqAsh wants to merge 25 commits into from
+126 −92

Conversation

@SaqAsh
Copy link

@SaqAsh SaqAsh commented Jul 30, 2025 •
edited
Loading

Summary

Reusable Navbar link component that is used for stage's navigation bar

Issues

Readiness Checklist

  • Self Review
    • I have performed a self review of code
    • I have run the application locally and manually tested the feature
    • I have checked all updates to correct typos and misspellings
  • Formatting
    • Code follows the project style guide
    • Autmated code formatters (ie. Prettier) have been run
  • Local Testing
    • Successfully built all packages locally
    • Successfully ran all test suites, all unit and integration tests pass
  • Updated Tests
    • Unit and integration tests have been added that describe the bug that was fixed or the features that were added
  • Documentation
    • All new environment variables added to .env.schema file and documented in the README
    • All changes to server HTTP endpoints have open-api documentation
    • All new functions exported from their module have TSDoc comment documentation

Saqib Ashraf and others added 23 commits May 8, 2025 09:28
TASK-220 Add data dictionary page and link it from homepage button
6847ba6
TASK-220 Add data dictionary page component with header and footer fo…
efe17da 
…r consistency
TASK-220 Add active state to Data Dictionary Button
167d4ce
add appropriate licensing comments
a0c38da
TASK-220 Add back .env.schema file, according to PR Review
eb8c051
@SaqAsh @justincorrigible
TASK-220 Update pages/data-dictionary/index.tsx with absolute imports
f055441 
Co-authored-by: Anders Richardsson <2107110+justincorrigible@users.noreply.github.com>
@SaqAsh @justincorrigible
TASK-220 Update components/pages/data-dictionary/index.tsx with absol…
b773bc0 
…ute import

Co-authored-by: Anders Richardsson <2107110+justincorrigible@users.noreply.github.com>
@justincorrigible
restore blank endline in .env.schema
df37e4d
TASK-220 rename DataDictionaryButton.tsx to LinkToDataDictionary.tsx …
db64bbf 
…for clarity
Merge branch 'feature/TASK-220-create-dictionary-page-in-stage' of ht…
3def2e5 
…tps://github.com/SaqAsh/stage into feature/TASK-220-create-dictionary-page-in-stage
change copyright from 2022 to 2025 and use prettier for formatting code
8a80412
@SaqAsh
Merge pull request #225 from SaqAsh/feature/TASK-220-create-dictionar…
9030f84 
…y-page-in-stage

Feature/task 220 create dictionary page in stage
refactor navbar link buttons such that they are in one component
cf31fce
make css changes to move link buttons to the left hand side of the na…
aaca04b 
…vbar
initial commit, repurpose dropdown for user to be used in the navbar,…
e3a573a 
… need to add functionality to mimic prelude
@SaqAsh
undo constants change and delete data dictionary page
8acc3b0
@SaqAsh
some cleanup
b5e932f
@SaqAsh
revert types
071c5fa
@SaqAsh
get rid of data dictionary page again
012dc50
@SaqAsh
revert button since it is a scary place
d1546de
@SaqAsh
navbar link refactor
80167c3
@SaqAsh
slight navbar cleanup
ab8af2e
@SaqAsh
Merge branch 'main' into feature/reuseable-navbar-link-component
118e502
@SaqAsh SaqAsh changed the title Feature/reuseable navbar link component Navbar Link Component Jul 30, 2025
@SaqAsh SaqAsh changed the title Navbar Link Component #234 - Navbar Link Component Jul 30, 2025
@SaqAsh SaqAsh requested a review from ciaranschutte July 31, 2025 12:34
@SaqAsh SaqAsh marked this pull request as ready for review July 31, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ciaranschutte ciaranschutte Awaiting requested review from ciaranschutte

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SaqAsh @justincorrigible