feat: fallback arm64 to x64 architecture for win32 platform #131

xhyrom · 2025-07-10T18:15:39Z

closes #130

RiskyMH · 2025-07-10T18:24:15Z

probably should throw warning letting user know this is emulating the x64 version with microsofts emulator and not actually using a native arm build, so as result it may be buggy.

for example use the https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message method so it shows up in the status page where they will see if it the workflow failed.

xhyrom · 2025-07-10T18:25:05Z

probably should throw warning letting user know this is emulating the x64 version with microsofts emulator and not actually using a native arm build, so as result it may be buggy.

for example use the https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message method so it shows up in the status page where they will see if it the workflow failed.

good idea 👍

Copilot

Pull Request Overview

Adds a temporary workaround for missing ARM64 Windows builds of Bun by falling back to x64 and updates the CI matrix to include an ARM Windows runner.

Introduce getEffectiveArch to map arm64→x64 on Windows and emit a warning.
Update getDownloadUrl to use getEffectiveArch.
Expand GitHub Actions matrix with windows-11-arm.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
src/action.ts	Add `getEffectiveArch` and integrate it into download URL encoding
.github/workflows/test.yml	Add `windows-11-arm` to the list of test runners

Comments suppressed due to low confidence (5)

.github/workflows/test.yml:53

The windows-11-arm runner label is not a standard GitHub-hosted runner and will cause CI failures. Replace it with a valid ARM runner label or use a self-hosted runner.

          - windows-11-arm

.github/workflows/test.yml:92

Duplicate invalid runner label here; CI will not recognize windows-11-arm. Consolidate or correct all occurrences.

          - windows-11-arm

.github/workflows/test.yml:159

This step also uses the non-existent windows-11-arm runner. Please ensure all matrix entries use valid runner names.

          - windows-11-arm

src/action.ts:158

There are no existing unit tests covering the new getEffectiveArch fallback behavior. Consider adding tests to verify Windows ARM64 is correctly remapped to x64 and the warning is emitted.

function getEffectiveArch(os: string, arch: string): string {

src/action.ts:158

[nitpick] Consider adding a JSDoc comment above getEffectiveArch to explain its purpose and parameters for future maintainers.

function getEffectiveArch(os: string, arch: string): string {

xhyrom · 2025-07-10T18:50:46Z

blocked until the bug in bun's download api is fixed

ericLemanissier · 2025-07-21T08:28:02Z

@xhyrom is this till blocked ? can it be re-triggered ? thanks !

xhyrom · 2025-07-21T08:32:18Z

@xhyrom is this till blocked ? can it be re-triggered ? thanks !

this is still blocked because of bug in bun's download api, cc @RiskyMH

xhyrom · 2026-01-04T00:18:00Z

blocked by #93

coderabbitai · 2026-01-04T23:05:45Z

Warning

Rate limit exceeded

@xhyrom has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 23 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a9fae19 and 0789115.

📒 Files selected for processing (1)

tests/utils.spec.ts

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Adds Windows ARM support by implementing architecture detection that falls back Windows ARM to x64, introduces AVX2 flag handling for Windows ARM, extends test matrix to include windows-11-arm, and adds corresponding unit tests.

Changes

Cohort / File(s)	Summary
Workflow Configuration `.github/workflows/test.yml`	Adds `windows-11-arm` to matrix configurations for both `setup-bun` and `setup-bun-from-file` workflows, enabling Bun setup testing on Windows 11 ARM
Windows ARM Support Implementation `src/utils.ts`, `src/download-url.ts`	Updates `getArchitecture(os, arch)` to return x64 for Windows ARM with warning; introduces `getAvx2(os, arch, avx2?)` for platform-aware AVX2 determination; modifies download-url to use these helper functions instead of direct option access
Test Coverage `tests/utils.spec.ts`	Adds unit tests for `getAvx2` covering Windows ARM/aarch64, x64 architectures across linux/darwin/windows with default and explicit AVX2 behavior validation

Pre-merge checks

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title accurately reflects the main change: implementing a fallback from ARM64 to x64 architecture on Windows.
Description check	✅ Passed	The description references the linked issue #130 which is clearly related to the changeset addressing Windows ARM64 support.
Linked Issues check	✅ Passed	The code changes implement the required fallback logic: getArchitecture returns x64 for Windows ARM64, getAvx2 disables AVX2 for Windows ARM64, download URL uses the fallback, and tests validate the behavior.
Out of Scope Changes check	✅ Passed	All changes are in scope: architecture fallback logic in src/utils.ts and src/download-url.ts, corresponding unit tests, and CI matrix expansion to test on windows-11-arm.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/download-url.ts

src/utils.ts

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/download-url.ts

src/utils.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-01-04T23:29:02Z

@xhyrom I've opened a new pull request, #153, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-04T23:29:08Z

@xhyrom I've opened a new pull request, #154, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Add unit tests for getAvx2 function Co-authored-by: xhyrom <56601352+xhyrom@users.noreply.github.com> * Consolidate duplicate test assertions in getAvx2 tests Co-authored-by: xhyrom <56601352+xhyrom@users.noreply.github.com> * Fix whitespace formatting in test file Co-authored-by: xhyrom <56601352+xhyrom@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: xhyrom <56601352+xhyrom@users.noreply.github.com>

coderabbitai

Actionable comments posted: 2

♻️ Duplicate comments (1)

src/utils.ts (1)
46-46: Check for both "windows" and "win32" OS identifiers.

The condition only checks for os === "windows", but users might explicitly provide os: "win32" in action inputs (matching Node.js's process.platform value). When os is explicitly provided, it bypasses the getPlatform() normalization that converts "win32" to "windows", causing the fallback logic to fail.

The same issue exists in getAvx2 at line 65.
🔎 Recommended fix to handle both identifiers
-  if (os === "windows" && (arch === "aarch64" || arch === "arm64")) {
+  if ((os === "windows" || os === "win32") && (arch === "aarch64" || arch === "arm64")) {
Apply the same fix to getAvx2 at line 65:
-  if (os === "windows" && (arch === "aarch64" || arch === "arm64")) {
+  if ((os === "windows" || os === "win32") && (arch === "aarch64" || arch === "arm64")) {

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8c296f9 and a9fae19.

⛔ Files ignored due to path filters (1)

dist/setup/index.js is excluded by !**/dist/**

📒 Files selected for processing (4)

.github/workflows/test.yml
src/download-url.ts
src/utils.ts
tests/utils.spec.ts

🧰 Additional context used

🧬 Code graph analysis (2)

tests/utils.spec.ts (1)

src/utils.ts (1)

getAvx2 (63-70)

src/download-url.ts (1)

src/utils.ts (3)

getArchitecture (45-61)

getPlatform (38-43)

getAvx2 (63-70)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: setup-bun from (windows-latest, package.json (packageManager yarn@bun@1.1.0))

🔇 Additional comments (3)

.github/workflows/test.yml (1)

53-53: LGTM! Appropriate test coverage for Windows ARM64 fallback.

Adding windows-11-arm to the test matrices for setup-bun and setup-bun-from-file workflows ensures the new fallback logic is validated on the target platform. The exclusion of this OS from setup-bun-download-url is appropriate since that workflow manually constructs download URLs without the architecture fallback.

Also applies to: 102-102

src/download-url.ts (1)

53-60: LGTM! Previous review issues have been addressed.

The architecture resolution correctly:

Calls getArchitecture() unconditionally, ensuring the Windows ARM64 fallback applies even when arch is explicitly provided

Uses getPlatform() to normalize process.platform from "win32" to "windows"

Passes the original (untransformed) arch value to getAvx2(), which is correct since it needs to detect Windows ARM64 before the transformation to x64

tests/utils.spec.ts (1)

1-49: LGTM! Comprehensive test coverage for getAvx2.

The tests thoroughly validate the getAvx2 function across multiple dimensions:

Windows ARM64/aarch64 behavior (returns false regardless of avx2 input)

Explicit avx2 values on various platforms

Default behavior (returns true) for non-Windows-ARM64 configurations

The test structure is clear, and all code paths are covered.

src/utils.ts

…llback logic (#153) * Initial plan * Add unit tests for getArchitecture function Co-authored-by: xhyrom <56601352+xhyrom@users.noreply.github.com> * Remove unused import in utils.spec.ts Co-authored-by: xhyrom <56601352+xhyrom@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Merge pr-131 and resolve test file conflicts Co-authored-by: xhyrom <56601352+xhyrom@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: xhyrom <56601352+xhyrom@users.noreply.github.com> Co-authored-by: Jozef Steinhübl <generalkubo@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

xhyrom and others added 3 commits July 10, 2025 20:15

feat: fallback arm64 to x64 architecture for win32 platform

5b3afef

closes #130

[autofix.ci] apply automated fixes

f5a2b42

ci: test on windows-11-arm runner

c2c1757

xhyrom requested a review from Copilot July 10, 2025 18:16

This comment was marked as outdated.

Sign in to view

refactor: move logic to getEffectiveArch func

bcfe2a9

[autofix.ci] apply automated fixes

debe80b

feat: add warning message for windows arm64 fallback to x64

356b959

xhyrom requested a review from Copilot July 10, 2025 18:28

Copilot AI reviewed Jul 10, 2025

View reviewed changes

autofix-ci bot and others added 8 commits July 10, 2025 18:30

[autofix.ci] apply automated fixes

7765e2b

feat: don't mention arch in warning msg aboout fallback

9cd774b

[autofix.ci] apply automated fixes

da7144a

debug time

82ac8fc

[autofix.ci] apply automated fixes

e006d01

feat: force baseline for win32 arm fallback to x64

6edb297

[autofix.ci] apply automated fixes

de1857b

ci: dont use windows-11-arm on setup bun from download url

79ccc41

xhyrom added the blocked label Jul 10, 2025

conflicts

1bd9781

xhyrom and others added 3 commits January 5, 2026 00:10

fix

5bd333e

[autofix.ci] apply automated fixes

cd6143a

fix

bc36c22

[autofix.ci] apply automated fixes

cecad8a

xhyrom requested a review from Copilot January 4, 2026 23:13

Copilot started reviewing on behalf of xhyrom January 4, 2026 23:13 View session

xhyrom and others added 2 commits January 5, 2026 00:15

fix

a711ea9

[autofix.ci] apply automated fixes

a082f44

Copilot AI reviewed Jan 4, 2026

View reviewed changes

src/download-url.ts Outdated Show resolved Hide resolved

src/utils.ts Show resolved Hide resolved

src/utils.ts Show resolved Hide resolved

xhyrom and others added 4 commits January 5, 2026 00:16

fix

83e822a

[autofix.ci] apply automated fixes

5dd7893

fix

7421b24

[autofix.ci] apply automated fixes

df80630

xhyrom removed the blocked label Jan 4, 2026

xhyrom requested a review from Copilot January 4, 2026 23:22

Copilot started reviewing on behalf of xhyrom January 4, 2026 23:22 View session

Copilot AI reviewed Jan 4, 2026

View reviewed changes

src/download-url.ts Outdated Show resolved Hide resolved

src/utils.ts Outdated Show resolved Hide resolved

src/utils.ts Show resolved Hide resolved

src/utils.ts Show resolved Hide resolved

src/utils.ts Show resolved Hide resolved

xhyrom and others added 4 commits January 5, 2026 00:27

apply changes

60ff058

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

[autofix.ci] apply automated fixes

077fd77

docs: clarify

f233c29

[autofix.ci] apply automated fixes

906d50b

Copilot AI mentioned this pull request Jan 4, 2026

test: add unit tests for getArchitecture and getAvx2 Windows ARM64 fallback logic #153

Merged

Copilot AI mentioned this pull request Jan 4, 2026

test: add unit tests for getAvx2 Windows ARM64 fallback logic #154

Merged

coderabbitai bot reviewed Jan 5, 2026

View reviewed changes

src/utils.ts Show resolved Hide resolved

src/utils.ts Show resolved Hide resolved

xhyrom merged commit b02f8a8 into main Jan 5, 2026
71 checks passed

feat: fallback arm64 to x64 architecture for win32 platform #131

feat: fallback arm64 to x64 architecture for win32 platform #131

Uh oh!

Conversation

xhyrom commented Jul 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

RiskyMH commented Jul 10, 2025

Uh oh!

xhyrom commented Jul 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

xhyrom commented Jul 10, 2025

Uh oh!

ericLemanissier commented Jul 21, 2025

Uh oh!

xhyrom commented Jul 21, 2025

Uh oh!

xhyrom commented Jan 4, 2026

Uh oh!

coderabbitai bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Other AI code review bot(s) detected

Walkthrough

Changes

Pre-merge checks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Jan 4, 2026 •

edited

Loading