This repository was archived by the owner on Aug 4, 2022. It is now read-only.
Dynamically get all available ratings#12
Open
Tickles-BV wants to merge 3 commits intoovanschie:masterfrom
Open
Dynamically get all available ratings#12Tickles-BV wants to merge 3 commits intoovanschie:masterfrom
Tickles-BV wants to merge 3 commits intoovanschie:masterfrom
Conversation
Apply fixes from StyleCI
Get all available ratings and iterate over them and their options to build the rating_options array, instead of hardcoding. This ensures custom ratingsget faked data too.
Tickles-BV
force-pushed
the
dynamic-ratings
branch
from
bcf185a to
e30ac26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get all available ratings and iterate over them and their options to build the rating_options array, instead of hardcoding. This ensures custom ratings get faked data too.