Skip to content

fix: spider chart with variable data points #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psterpu-c merged 4 commits into from
Oct 3, 2025
Merged

fix: spider chart with variable data points #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be7dfdd
fix: spider chart with variable data points
psterpu-c Oct 3, 2025
cdcfe2c
Merge branch 'main' into spider-chart
psterpu-c Oct 3, 2025
c59e8a0
fix: lint
psterpu-c Oct 3, 2025
140390b
fix: storybook
psterpu-c Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/open-ui-kit/src/charts/spider-chart/components/spider-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const calculateDomain = (data: ExtendedDataPoint[]) => [
export const SpiderChart = ({
data,
radars,
band = 30,
tickBand = 5,
scale = 1,
outerRadius = 90,
Expand Down Expand Up @@ -78,6 +77,9 @@ export const SpiderChart = ({
);
});

const angleStep = 360 / data.length;
const computedAngleOffset = 90 % angleStep;

return (
<StyledRadarChart onClick={handleClick}>
<ResponsiveContainer width="100%" height="100%">
Expand All @@ -95,7 +97,7 @@ export const SpiderChart = ({
data={[{ subject: "1" }]}
polarAngles={Array(data.length)
.fill(0)
.map((_, i) => i * (360 / data.length) + tickBand)}
.map((_, i) => i * angleStep + tickBand)}
/>
<Customized
component={CustomPolarGrid}
Expand All @@ -107,7 +109,7 @@ export const SpiderChart = ({
scale={scale}
polarAngles={Array(data.length)
.fill(0)
.map((_, i) => i * (360 / data.length) + band)}
.map((_, i) => i * angleStep + computedAngleOffset)}
/>
<Customized
component={CustomLines}
Expand All @@ -120,7 +122,7 @@ export const SpiderChart = ({
outerRadius={1}
polarAngles={Array(data.length)
.fill(0)
.map((_, i) => i * (360 / data.length) + band)}
.map((_, i) => i * angleStep + computedAngleOffset)}
/>

{radars.map((radar, index) => (
Expand Down
5 changes: 4 additions & 1 deletion packages/open-ui-kit/src/charts/spider-chart/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,7 @@
*/

export { SpiderChart } from "./components/spider-chart";
export type { SpiderChartProps } from "./types/spider-chart.types";
export type {
SpiderChartProps,
ExtendedDataPoint,
} from "./types/spider-chart.types";
3 changes: 0 additions & 3 deletions packages/open-ui-kit/src/charts/spider-chart/stories/spider-chart.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ const meta: Meta<typeof SpiderChart> = {
outerRadius: {
description: "The outer radius of the chart.",
},
band: {
description: "The outer radius of the chart",
},
onTooltipClick: {
description: "Callback to call on tooltip click",
},
Expand Down
1 change: 0 additions & 1 deletion packages/open-ui-kit/src/charts/spider-chart/types/spider-chart.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export type SpiderChartProps = {
radars: RadarType[];
outerRadius?: number;
padData?: number;
band?: number;
onTooltipClick?: (subject: string) => void;
tooltipContent?: (dataPoint: ExtendedDataPoint) => React.ReactNode;
showTooltip?: boolean;
Expand Down