Polishing required for Project-Setup#2
Open
peregurin-outscal wants to merge 4 commits intoProject-Setupfrom
Open
Polishing required for Project-Setup#2peregurin-outscal wants to merge 4 commits intoProject-Setupfrom
peregurin-outscal wants to merge 4 commits intoProject-Setupfrom
Conversation
code cleanup changes to enemy and player SO for delay
mridul-outscal
approved these changes
Nov 17, 2023
| RotatePlayer(movementDirection); | ||
| MovePlayer(movementDirection); | ||
| }else{ | ||
| playerView.PlayMovementAnimation(true); |
Contributor
There was a problem hiding this comment.
we are playing player movement animation if there is no player input?
Collaborator
Author
There was a problem hiding this comment.
That's the common function for idle and movement animation. I pass the boolean for the same to change the state
The one used in the above is for idle animation (passing isIdle = true)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.