Add systemd socket activation support#1
Open
wmanley wants to merge 1 commit intooutbrain-inc:masterfrom
Open
Conversation
With this the socket that torch will be listening on is opened before
torch is started and passed in. This is more flexible because the
socket no longer needs to be SOCK_INET. We'll be using a unix domain
socket. It also simplifies startup as I can choose to bind mount this
unix socket into containers before torch has started.
To test this out run:
systemd-socket-activate -l 127.0.0.1:7654 python -m torch
and torch will be listening on http://localhost:7654 .
Systemd unit files are provided for reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this the socket that torch will be listening on is opened before
torch is started and passed in. This is more flexible because the
socket no longer needs to be SOCK_INET. We'll be using a unix domain
socket. It also simplifies startup as I can choose to bind mount this
unix socket into containers before torch has started.
To test this out run:
and torch will be listening on http://localhost:7654 .
Systemd unit files are provided for reference.