Enforce login on tenant domains in OrganizationMiddleware and add tests#10
Open
oumafreddy wants to merge 1 commit intomasterfrom
Open
Enforce login on tenant domains in OrganizationMiddleware and add tests#10oumafreddy wants to merge 1 commit intomasterfrom
oumafreddy wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
apps/core/middleware.pyOrganizationMiddlewareto return a redirect to the login page when arequest.tenantis present and therequest.useris not authenticated, moving the authentication enforcement earlier in the request flow.apps/users/tests/test_organization_middleware.pyto cover anonymous access on the public site, required login for tenant sites, and allowed access for authenticated users belonging to the tenant.Testing
python manage.py test apps.users.tests.test_organization_middlewareand all tests passed.Codex Task