This repository was archived by the owner on Aug 11, 2020. It is now read-only.
Open
Conversation
The reasoning behind this PR is that lfetool contains some bashisms that the shell will choke on in the case of systems where /bin/sh is not bash (eg. Debian and derivatives, where /bin/sh is dash).
|
Wouldn't it be better to go the other way and remove all bashisms from lfetool instead? Didn't this discussion crop up in #erlang-lisp? |
Author
|
In short, yes on both counts The conversation did pop up on #erlang-lisp, in reaction to this PR :) Chatter 'evax' suggested using the "checkbashisms" tool (on a Debian [or Ubuntu, I presume] system, this is part of the "devtools" package) as a way to expedite this process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reasoning behind this PR is that lfetool contains some bashisms that the shell will choke on in the case of systems where /bin/sh is not bash (eg. Debian and derivatives, where /bin/sh is dash).