AO3-7271 Add cloudflare bot score and fingerprints to akismet comment spam checks

[omerfaruk-pseud]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7271

Purpose

When the instance uses Cloudflare, add Cloudflare's information - which will be available on the request headers- to akismet comment checks for better accuracy. It will not add anything otherwise.

Credit

ömer faruk (he/him)
marcus8448, for the tests

[omerfaruk-pseud]

I couldn't figure out how to add response headers in tests, the current one just compares nil to nil. How can I properly test this?

[marcus8448]

I think a controller test should work (see comments/default_rails_actions_spec.rb)

[marcus8448]

This should be request.headers (headers is for response headers).

[omerfaruk-pseud]

Huh, Jira ticket says "available in the response header" though?

[omerfaruk-pseud]

I've tried writing a test there too, the problem was even when I added cf info to response.headers it was resetting back to default headers when creating the comment and setting akismet_attributes from there.

[marcus8448]

Huh, Jira ticket says "available in the response header" though?

I think that might be a mistake in the ticket.

I've tried writing a test there too, the problem was even when I added cf info to response.headers it was resetting back to default headers when creating the comment and setting akismet_attributes from there.

I'm fairly certain setting request.headers should work? But the actual testing is a bit more complicated since the cloudflare attributes are short lived on the Comment. I'm not sure what the best practices are here so I'll open this up for someone else to review.

[zz9pzza]

So what we use else where is req.env["HTTP_X_UNICORNS"]

Like https://github.com/otwcode/otwarchive/blob/master/config/initializers/rack_attack.rb#L48

It's what we get in the request ( the information is inserted by cloudflare )