AO3-7263 Error 500 when accessing user preferences as an admin for a user that has locale preferences enabled

[not-varram]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7263

Purpose

Fixes incorrect reference to current_user.preference.locale_for_mails in the preferences view. The view was using current_user.preference instead of the already-loaded @preference instance variable, which could potentially cause errors and was inconsistent with the rest of the form.

Changes:

• Updated line 76 in app/views/preferences/index.html.erb to use @preference.locale_for_mails instead of current_user.preference.locale_for_mails
• This makes it consistent with other references in the same view (e.g., @preference.preferred_locale on line 78)
• Follows the same pattern used in app/views/help/preferences_locale.html.erb

Testing Instructions

1. Login as policy_and_abuse, support or superadmin admin
2. Navigate to a user’s preferences page
   a. Browse > Works
   b. Follow the link to an author’s pseud
   c. Click on preferences in the user sidebar
3. Now just ensure the page loads and you dont see any errors

Credit

varram (he/him)

[marcus8448]

Hi varram,

Thanks for the pull request! It would be great if you could also add a test for this issue. (You might find preferences_edit.feature helpful when doing so)

[not-varram]

hey! @marcus8448 I've made the changes you requested. Let me know if this is fine? (I'm pretty new to contributing to ao3 so any feedback is appreciated :))

[marcus8448]

Implementation looks good! Just two notes for the tests.