AO3-7036 Make thread button appear even if comment is unreviewed#5380
Closed
Nil-Cipher wants to merge 1 commit intootwcode:masterfrom
Closed
AO3-7036 Make thread button appear even if comment is unreviewed#5380Nil-Cipher wants to merge 1 commit intootwcode:masterfrom
Nil-Cipher wants to merge 1 commit intootwcode:masterfrom
Conversation
Collaborator
|
Good to see you again, Wanda! We typically prefer to test changes to views in our integration tests. For small changes like this, the easiest thing to do is usually look around and see if there's an existing test you can modify. In this case, this scenario testing moderated comments in threads is probably a good candidate. You can find some info on working with these tests on our Automated Testing wiki page, but if you have specific questions, please let us know! |
Contributor
|
Adopted at #5562 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
render_templatething? I didn't find any existing tests for_comment_actions, and this is my first time developing in ruby so I'm unfamiliar with the tooling.as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7036
Purpose
This PR fixes the bug where unreviewed comments do not have the 'Thread' button show up.
Testing Instructions
Reproduce the issue following the instructions in the jira.
References
Are there other relevant issues/pull requests/mailing list discussions? If not, you can remove this section.
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
Wanda Song
she/her