Skip to content

AO3-7036 Make thread button appear even if comment is unreviewed#5380

Closed
Nil-Cipher wants to merge 1 commit intootwcode:masterfrom
Nil-Cipher:master
Closed

AO3-7036 Make thread button appear even if comment is unreviewed#5380
Nil-Cipher wants to merge 1 commit intootwcode:masterfrom
Nil-Cipher:master

Conversation

@Nil-Cipher
Copy link
Contributor

@Nil-Cipher Nil-Cipher commented Oct 2, 2025

Pull Request Checklist

  • Have you read "How to write the perfect pull request"?
  • Have you read the contributing guidelines?
  • Have you added tests for any changed functionality?
    • I'm still new to contributing and wasn't sure how to add a test for this. Maybe some render_template thing? I didn't find any existing tests for _comment_actions, and this is my first time developing in ruby so I'm unfamiliar with the tooling.
  • Have you added the Jira issue number
    as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
  • Do you have fewer than 5 pull requests already open? If not, please wait
    until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-7036

Purpose

This PR fixes the bug where unreviewed comments do not have the 'Thread' button show up.

Testing Instructions

Reproduce the issue following the instructions in the jira.

References

Are there other relevant issues/pull requests/mailing list discussions? If not, you can remove this section.

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
Wanda Song
she/her

@Nil-Cipher Nil-Cipher marked this pull request as ready for review October 2, 2025 07:15
@sarken
Copy link
Collaborator

sarken commented Oct 3, 2025

Good to see you again, Wanda!

We typically prefer to test changes to views in our integration tests. For small changes like this, the easiest thing to do is usually look around and see if there's an existing test you can modify. In this case, this scenario testing moderated comments in threads is probably a good candidate.

You can find some info on working with these tests on our Automated Testing wiki page, but if you have specific questions, please let us know!

@Bilka2
Copy link
Contributor

Bilka2 commented Jan 25, 2026

Adopted at #5562

@Bilka2 Bilka2 closed this Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants