Skip to content

Conversation

@adrian200223
Copy link

@adrian200223 adrian200223 commented Dec 8, 2020

Just as I was confused about the Voice Server field (specially in regards to the port), other people may be too.

I added a line creating an example of what the Voice Server field would look like if you deployed the app on heroku.

Edited for better wording

@OhMyGuus
Copy link

OhMyGuus commented Dec 8, 2020

If the port that the server uses is 80 u don't have to define it in the client, the voice server URL is then http://crewlink.herokuapp.com not crewlink.herokuapp.com:80 like u stated in your change.

@adrian200223
Copy link
Author

If the port that the server uses is 80 u don't have to define it in the client, the voice server URL is then http://crewlink.herokuapp.com not crewlink.herokuapp.com:80 like u stated in your change.

"crewlink.herokuapp.com:80" is also valid. "crewlink.herokuapp.com" is translated to the respective IP (via DNS) and then the port used is 80 (same with a http get request). Both forms are valid.

I did not try "crewlink.herokuapp.com" because I thought I had to specify the port (I now know 80 is the default). Also, including https:// is optional (did not know that as well).

I just thoght that this documentation needed an example to all newbies like me. I think it could be good to specify that:
"crewlink.herokuapp.com", "crewlink.herokuapp.com:80" and "https://crewlink.herokuapp.com" are valid examples.

adrian200223 and others added 2 commits December 14, 2020 13:52
Co-authored-by: Scott Brenner <scott@scottbrenner.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants