Fix #128: avoid Marshal-ing exn value via closure#129
Open
dc-mak wants to merge 2 commits intoott-lang:masterfrom
Open
Fix #128: avoid Marshal-ing exn value via closure#129dc-mak wants to merge 2 commits intoott-lang:masterfrom
dc-mak wants to merge 2 commits intoott-lang:masterfrom
Conversation
This commit fixes an observed discrepancy between running a TeX filter straight after parsing an Ott file, or after caching it and reading the cache. I believe the issue is that the code for the exception handler inside the Marshal'd closure captures a value for the exception which is not guaranteed to be preserved: https://ocaml.org/manual/5.3/api/Marshal.html#:~:text=Values%20of%20extensible,work%20as%20expected https://stackoverflow.com/a/54872172 One can observe this by debug-printing the tags associated with the exception using the diff mentioned in [this comment](ott-lang#128 (comment)).
dc-mak
added a commit
to dc-mak/PhD-Thesis
that referenced
this pull request
May 5, 2025
This exposes a bug in Ott (ott-lang/ott#128) and so I am using a patched version whilst the PR (ott-lang/ott#129) is reviewed and merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.