Fix Stack_overflow for filtering a file#102
Open
westpaddy wants to merge 1 commit intoott-lang:masterfrom
Open
Fix Stack_overflow for filtering a file#102westpaddy wants to merge 1 commit intoott-lang:masterfrom
westpaddy wants to merge 1 commit intoott-lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation rarely raises the Stack_overflow exception for filtering some particular files. I encountered the situation with a file containing a rather long
[[ ... ]]being parsed.This fix replaces non-tail-recursive functions related to the problem with tail-recursive ones. I believe this fix causes minor performance issues for at least filtering files the current implementation can handle because only a short list is dealt with in such cases. The fix may be more efficient if we well understand the algorithm, though. For example, we can remove
List.revif a list used in the algorithm is order-irrespective.