Conversation
Co-authored-by: vromanichev24 <vromanichev24@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Pull Request Test Coverage Report for Build 19872606544Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 19872606544Details
💛 - Coveralls |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| apk --no-cache add icu-libs icu-data-full icu-dev; \ | ||
| apk --no-cache add pcre-dev ${PHPIZE_DEPS}; \ | ||
| PHP_MAJOR="${VERSION%%.*}"; \ | ||
| if [ "${PHP_MAJOR}" -lt 8 ]; then \ |
There was a problem hiding this comment.
Bug: ARG variable not available inside RUN command
The VERSION ARG declared before FROM is not available in the RUN instruction. Docker ARG variables declared before FROM are only scoped to the FROM line itself and must be re-declared after FROM to be used in subsequent instructions. As a result, ${VERSION} will be empty, making PHP_MAJOR empty, and the comparison [ "${PHP_MAJOR}" -lt 8 ] will fail with an integer expression error. Adding ARG VERSION after the FROM line would make the variable available in the build stage.
Add Xdebug version selection to Dockerfile to prevent incompatibility errors when building images with different PHP versions.
Note
Adds conditional Xdebug version selection based on PHP major and refactors Dockerfile install steps for reliability.
docker/Dockerfile):PHP_MAJORfromVERSIONand installsxdebug-3.1.6for PHP < 8, otherwisexdebug.docker-php-ext-enable xdebug.set -euxand consolidatesapkcommands with--no-cache.linux-headers, ICU libs/dev,pcre-dev+${PHPIZE_DEPS}during build; removes them after.bcmath,intl, and Composer 2.Written by Cursor Bugbot for commit 0861c1f. This will update automatically on new commits. Configure here.