fixed https #5
Open
fixed https #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@dutchwhizzman thank you for this PR. |
Owner
|
@dutchwhizzman Can you fix the version mix? We will see for a parameter soon :) On my side, i'll work to improve CI. It will be much better to work together :p |
Fixed version numbering
Author
|
Version number changed to 13.0.7 (latest 13 as of now) |
Author
|
Oops, wrong button. |
Owner
|
No problem, but you triggered CI :p |
Owner
|
@dutchwhizzman any news regarding it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some config options, fixed https by basically copying the entire server section in both sections for https true/false. I also changed a flag for fastcgi so it will automatically do https if this is enabled.
This works for me for non-https. I am still figuring out how to get it automated with certbot, so I haven't yet tested the https part of it. Even if that isn't working flawlessly, fixing it without breaking non-https should be a lot easier since both sections are completely independent now.
I now see that I have both 13.0.4 and 13.0.6 as versions mixed in my pull request. You may want to fix that.
One of my next steps will be to update such that the version can be in init.pp and based on that the URL for download will be generated. I will probably even try to figure out if I can script an upgrade so that an existing config will run the nextcloud upgrade script to upgrade to the preferred version.