Fixed back button glitch #663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/gallery
This adds support for https://sentry.io so that we can manage our application errors in a more sane fashion. For it to actually work, you need to setup projects on an account which we'll do on the OSL side. But for general development this doesn't require anything. You will need to rebuild your web docker image to test and use this since we import the raven (Sentry's python library) in settings.py.
Add Sentry.io reporting
't make the return value a NaN
Fix water quality graphing code (specifically data filtering)
Fixes Server 500 when school is deleted
removed educator kits and upload resource
Edge pages now display gallery and datasheets, drop downs work
Changed code to calculate sample averages
Fixed side scrolling issues on site details (affects laptops as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #656
Tested on: Chrome, Firefox, Safari (desktop & iphone), Edge
Changes in this PR.
Testing this PR.
Go to site page
Go to a site with a lot of datasheet and gallery data (might need to manually add them)
Click on the page number for both datasheet and gallery, and check the url in the browser. Make sure the change according to the page number clicked.
Important: The url parameter should be: "..../site_name/?datasheet={1}&gallery={2}" where {1} is the datasheet page number, and {2} is gallery page number. For each parameter in the url (datasheet/gallery), if the page number is 1, it should not appear.
Click "back" or "forward" button on browser repeatedly, make sure the page number you clicked are stored in history.
Manually input a test url to that specific site into browser, with different page numbers for each parameter (Make sure to test page numbers that are out of range). If the page number is out of range in url, the datasheet/gallery table page should load page number 1.
Make sure the rest of the page's functionality are not affected.
Expected Output.
@osuosl/devs