Draft
Conversation
arnaudlevy
requested review from
Olivia206,
SebouChu,
alexisben and
pabois
as code owners
Member
Author
|
@alexisben là mon traitement des liens ne marche juste pas. |
Contributor
djLintLinted 702 files, found 0 errors. HugolintDirectories are perfect ✅Partials calls are perfect ✅Too many lines (48)Files should not be too long, it's a sign of mess and a difficulty for overrides. 6 ❌
Complexity (21)Cyclomatic complexity should not be too high. 1 ❌
|
Contributor
|
j'ai l'impression que |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
https://checklists.opquast.com/fr/qualite-numerique/le-site-napplique-pas-le-meme-style-aux-liens-visites-et-non-visites
Et les composants étaient logiques quand c'était externe, mais il faut ranger maintenant que tout est interne. Soit on remet tout dans
design-system(rigoureux mais un peu trop d'objets), soit on met les objets un peu sophistiquées danscomponents(là, lelazy-video-player, mais peut-être aussioffcanvas,pagination,table_of_contents...)Niveau d'incidence