Open
Conversation
DiningDAOTest checks that IcalUtil.getEventsForDay returns the correct days by comparing against hardcoded dates. But the hardcoded dates are constructed without an explicit timezone, so they default to the system time. This meant that the test would fail if the system timezone was not set to US Pacific time. Fix this by setting an explicit timezone.
magical
force-pushed
the
feature/timezone-fix
branch
from
deff1c0 to
eed24ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiningDAOTest checks that IcalUtil.getEventsForDay returns the correct
days by comparing against hardcoded dates. But the hardcoded dates are
constructed without an explicit timezone, so they default to the system
time. This meant that the test would fail if the system timezone was not
set to US Pacific time.
Fix this by setting an explicit timezone.