Implement new scg format #434
Conversation
| const QString& contentFilename() const; | ||
| const QVariant& contentData() const; | ||
| int idtfPos() const; | ||
| QString scsId() const; |
There was a problem hiding this comment.
To discuss: why we need scs id in SCg object info
There was a problem hiding this comment.
we need to save this id, so that we can later find an element for which we will set the extended type.
see sources/plugins/scg/scs/scgobjectinforeader.cpp:99-103
| static const QHash<QString, QString> exendedTypes = | ||
| { | ||
| //! not define | ||
| { "sc_node_not_define", "node/-/-/not_define" }, |
There was a problem hiding this comment.
| { "sc_node_not_define", "node/-/-/not_define" }, | |
| { SCgConsts::SC_NODE_NOT_DEFINE, "node/-/-/not_define" }, |
Use constants
| { "pair/var/-/temp/noorien", ">" }, //not supported | ||
| { "pair/var/-/temp/orient", ">"}, //not supported | ||
|
|
||
| { "pair/meta/-/perm/noorien", ">" }, //not supported |
There was a problem hiding this comment.
We need process types like this(without scs sign) separate, by process access arc from types tot this arc
| "$$ANTLR_LIB_PATH"/runtime/src/tree/xpath/XPathTokenAnywhereElement.h \ | ||
| "$$ANTLR_LIB_PATH"/runtime/src/tree/xpath/XPathTokenElement.h \ | ||
| "$$ANTLR_LIB_PATH"/runtime/src/tree/xpath/XPathWildcardAnywhereElement.h \ | ||
| "$$ANTLR_LIB_PATH"/runtime/src/tree/xpath/XPathWildcardElement.h \ |
There was a problem hiding this comment.
KBE should depend on targets in sc-machine. And link existing (configured) targets.
Current way is very bad for support. Any changes in sc-machine will break compilation of KBE.
For that purposes we even can make scs-parser as separate target in sc-memory.
deniskoronchik
left a comment
deniskoronchik
left a comment
There was a problem hiding this comment.
I still think, that:
- efforts that already spent;
- efforts that are still required to finish this work;
- effort to support this in future
are too big.
Much easier to have one simple python script that do preprocessing of knowledge base sources during knowledge base build stage. This script should do one very simple thing - convert scg to scs. There are no any problem to add call of this script into shell script that builds knowledge base.
This simple solution allows to solve this problem in some hours instead of months.
4 participants
No description provided.