Skip to content

Conversation

@PikachuEXE
Copy link
Contributor

My previous PR #138 allows connection_pool 2.x but did not test against it (I tested it locally with this but forgot to add
Not new release needed just modification to testing
Also updated the size in test case to be sure (since using default value isn't a good test

@benubois
Copy link
Collaborator

Hey,

I’m feeling that adding a dependency to test another dependency is too much overhead.

I think that the way you implemented everything is backwards compatible, so is it necessary to test against ~> 2?

If the concern is to keep apnotic from breaking compatibility with 2 in the future, is there a simpler test possible like ensuring splatted args are always passed to ConnectionPool.new?

Thanks again for your work on this!

@PikachuEXE
Copy link
Contributor Author

If the concern is to keep apnotic from breaking compatibility with 2 in the future, is there a simpler test possible like ensuring splatted args are always passed to ConnectionPool.new?

No idea how to test like this

@PikachuEXE
Copy link
Contributor Author

What do you think about this PR if I removed the extra dependency appraisal (it's just for easier gemfile generation and local testing

@benubois
Copy link
Collaborator

Yeah, if it can be done without the dependency that would be great. Thanks!

@PikachuEXE PikachuEXE force-pushed the connection_pool_3-both branch from fa11683 to 0e9058b Compare January 13, 2026 00:51
@PikachuEXE PikachuEXE force-pushed the connection_pool_3-both branch from 0e9058b to 879cbaf Compare January 13, 2026 00:53
@PikachuEXE
Copy link
Contributor Author

Updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants