Skip to content

Conversation

@osteele
Copy link
Owner

@osteele osteele commented Nov 29, 2025

This PR addresses issue #48 by re-enabling code coverage reporting using GitHub Actions and Go's native coverage tools, without requiring external SaaS services like Codecov or Coveralls.

The blocking Go issue (golang/go#35781) causing "inconsistent NumStmt" errors has been worked around in commit 7ad8c5d by removing the -race flag from coverage runs.

Changes:

  • Replace Codecov integration with GitHub Actions native coverage
  • Extract and display coverage percentage in workflow summary
  • Add optional badge generation using GitHub gist (no external services)
  • Update documentation to reflect new coverage approach
  • Coverage generation works successfully (83.8% overall coverage)

Benefits of this approach:

  • No external SaaS dependencies or API tokens required
  • Coverage data visible in GitHub Actions workflow summary
  • Uses Go's built-in coverage tools
  • Badge generation is optional (requires GIST_SECRET if desired)
  • Follows modern best practices for Go projects in 2024-2025

Fixes #48

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

This PR addresses issue #48 by re-enabling code coverage reporting using
GitHub Actions and Go's native coverage tools, without requiring external
SaaS services like Codecov or Coveralls.

The blocking Go issue (golang/go#35781) causing "inconsistent NumStmt"
errors has been worked around in commit 7ad8c5d by removing the -race
flag from coverage runs.

Changes:
- Replace Codecov integration with GitHub Actions native coverage
- Extract and display coverage percentage in workflow summary
- Add optional badge generation using GitHub gist (no external services)
- Update documentation to reflect new coverage approach
- Coverage generation works successfully (83.8% overall coverage)

Benefits of this approach:
- No external SaaS dependencies or API tokens required
- Coverage data visible in GitHub Actions workflow summary
- Uses Go's built-in coverage tools
- Badge generation is optional (requires GIST_SECRET if desired)
- Follows modern best practices for Go projects in 2024-2025

Fixes #48
@osteele osteele merged commit 835ddf2 into main Nov 29, 2025
3 checks passed
@osteele osteele deleted the claude/code-coverage-review-011CUv7fxXMxPcMpyhW7CYuY branch November 29, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable code coverage report

3 participants