Implement OR operator #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements support for the 'or' operator in 'when' clauses
of case statements, matching the official Shopify Liquid specification.
Changes:
- Modified expressions.y grammar to accept 'or' as an alternative
separator to commas in the expr2 rule for when statements
- Regenerated y.go parser from the updated grammar
- Added comprehensive test cases for 'or' operator usage:
* Integer values with 'or' operator
* String values matching Shopify documentation examples
* Multiple 'or' operators (e.g., 1 or 2 or 3)
The implementation now supports both syntaxes as specified in the
Shopify documentation:
- Comma-separated: {% when 1, 2 %}
- OR operator: {% when 1 or 2 %}
- Multiple ORs: {% when 1 or 2 or 3 %}
All existing tests continue to pass, confirming backward compatibility.
Fixes #123
osteele
deleted the
claude/verify-fix-pr-123-01UCRoZQayY2nCMuHTMfmYsH
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements support for the 'or' operator in 'when' clauses of case statements, matching the official Shopify Liquid specification.
Changes:
The implementation now supports both syntaxes as specified in the Shopify documentation:
All existing tests continue to pass, confirming backward compatibility.