Skip to content

Conversation

@Prajeeth-12
Copy link
Collaborator

No description provided.

@Prajeeth-12 Prajeeth-12 linked an issue Oct 16, 2025 that may be closed by this pull request
@Prajeeth-12
Copy link
Collaborator Author

used some placeholder values for APIs ,

Copy link
Collaborator

@Munazzah-Rakhangi Munazzah-Rakhangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required before approval

Thanks for the integration work — the API wiring and signup flow connect successfully, but the frontend validation logic needs improvement. Right now, the form allows invalid or incomplete data to pass through and still create an account.

Issues observed:

Name: Accepts numeric input like “1234”. It should only allow alphabetic characters.
→ Show error: “Enter a valid name.”

Gender: Field can not be left empty. This should be mandatory.
→ Show error: “Please select a gender.”

Phone: Accepts non-numeric input like “abcd”. It should allow only valid phone numbers (digits, 10–15 chars).
→ Show error: “Enter a valid phone number.”

Password: Accepts weak passwords (e.g., “123456”). Must enforce:

Minimum 8 characters

At least 1 uppercase letter

At least 1 special character
→ Show error: “Please meet the password requirements.”

Action required:
Please add client-side validation for these fields before submission and prevent API calls when the input is invalid. Once this validation is in place, I’ll re-test and approve the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6.19) Connect Signup form → POST /auth/signup

3 participants