ENH: Add deptry, mypy to pre-commit hooks, add pre-commit-update#49
Open
alexrockhill wants to merge 2 commits intoosprey-oss:mainfrom
Open
ENH: Add deptry, mypy to pre-commit hooks, add pre-commit-update#49alexrockhill wants to merge 2 commits intoosprey-oss:mainfrom
alexrockhill wants to merge 2 commits intoosprey-oss:mainfrom
Conversation
Author
|
I really like this pre-commit updater, seems like a really nice to have! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Deptry and mypy are run in the Makefile in
make testwhich makes it so that the lint unit test can fail. Would make sense to me to move those to the pre-commit. Alsopre-commit-updateis nice to keep the hooks up-to-date.