fix: handle uncompressed transaction payloads beyond 2GB #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osheroff
reviewed
Dec 18, 2025
...ithub/shyiko/mysql/binlog/event/deserialization/TransactionPayloadEventDataDeserializer.java
Outdated
Show resolved
Hide resolved
osheroff
reviewed
Dec 18, 2025
...ithub/shyiko/mysql/binlog/event/deserialization/TransactionPayloadEventDataDeserializer.java
Outdated
Show resolved
Hide resolved
osheroff
reviewed
Dec 18, 2025
...ithub/shyiko/mysql/binlog/event/deserialization/TransactionPayloadEventDataDeserializer.java
Outdated
Show resolved
Hide resolved
osheroff
reviewed
Dec 18, 2025
| internalEvent = transactionPayloadEventDeserializer.nextEvent(destinationInputStream); | ||
| } | ||
| try (ZstdInputStream zstdInputStream = new ZstdInputStream(new java.io.ByteArrayInputStream(eventData.getPayload()))) { | ||
| ByteArrayInputStream destinationInputStream = new ByteArrayInputStream(zstdInputStream); |
Owner
There was a problem hiding this comment.
can you talk more about the need to move to using input streams here? the old code looked much simpler, did it overflow the output buffer?
osheroff
reviewed
Dec 19, 2025
| } | ||
|
|
||
| public void setPayloadSize(int payloadSize) { | ||
| public void setPayloadSize(long payloadSize) { |
Owner
There was a problem hiding this comment.
payloadSize can stay an int too i think
osheroff
reviewed
Dec 19, 2025
| // Read the size of the field (use readPackedLong to support large field sizes) | ||
| if (inputStream.available() >= 1) { | ||
| fieldLen = inputStream.readPackedInteger(); | ||
| fieldLen = inputStream.readPackedInt(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #171
Before:
After:
