Skip to content

INF-2227: Add documentation for COManage CO Group provisioning. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
williamnswanson wants to merge 4 commits into from
Closed

INF-2227: Add documentation for COManage CO Group provisioning. #144

williamnswanson wants to merge 4 commits into from

Conversation

@williamnswanson
Copy link
Contributor

@williamnswanson williamnswanson commented Aug 16, 2024

No description provided.

@williamnswanson williamnswanson self-assigned this Aug 16, 2024
@williamnswanson williamnswanson marked this pull request as ready for review August 16, 2024 21:16
@williamnswanson williamnswanson added the documentation Improvements or additions to documentation label Aug 20, 2024
mwestphall
mwestphall approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@mwestphall mwestphall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to follow this document to add a new COManage Group, looks good.

brianhlin
brianhlin requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got thoughts on formatting but will have to provide details at a later time

brianhlin
brianhlin reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See in-line comments. Mostly nit-picky stuff to adhere to our style guide: https://osg-htc.org/technology/documentation/style-guide/. Make sure to batch commits together when accepting suggestions (https://osg-htc.org/technology/software/git-software-development/#batch-commits-when-accepting-suggestions-from-a-review)

Also as a heads up, you should basically never submit PRs from your main / master branches as the default PR behavior is to allow the maintainer to add commits to your PR, i.e. your fork's main / master branch

@williamnswanson williamnswanson mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianhlin brianhlin brianhlin requested changes

@mwestphall mwestphall mwestphall approved these changes

Assignees

@williamnswanson williamnswanson

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@williamnswanson @brianhlin @mwestphall