fix(fasterdata): respect --dry-run for packet pacing; audit checks actual qdisc (v1.3.6) #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tual qdisc (v1.3.6) - iface_apply_packet_pacing: skip actions when --dry-run is set and log intent - iface_packet_pacing_audit: always inspect qdisc to detect pacing (ignore flag state) - bump version to 1.3.6 and add CHANGELOG entry - add regression test to verify dry-run behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related issues in
fasterdata-tuning.sh: (1)--mode auditreported packet pacing as not applied even when an fq/tbf qdisc was present, and (2) running--mode apply --dry-runcould appear to change state by performing actions that were not dry-run-safe.What I changed
iface_packet_pacing_audit: inspects the actual qdisc on interfaces and reports pacing applied iffqortbfis present.iface_apply_packet_pacing: honors--dry-run(logs intended actions and skips applying qdisc or writing services).v1.3.6and added a CHANGELOG entry.tests/test-fasterdata-dryrun.shto assert that--mode apply --dry-rundoes not apply qdisc and that audit output reflects actual qdisc state.Reproduction
tools/fasterdata-tuning.sh --mode apply --target dtn --apply-packet-pacing --dry-run— should not modify system or qdisc; logs show "Dry-run: would apply packet pacing...".tools/fasterdata-tuning.sh --mode audit --target dtnshould show "Packet pacing: ENABLED (qdisc=fq|tbf)" when a pacing qdisc is present.Tests
tests/test-fasterdata-dryrun.sh(added) verifies dry-run behavior locally.Please review; I will update or expand tests if you'd like additional coverage.