Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs several refactorings across the codebase, focusing on session management and state machine simplification.
Changes:
- Modified BackgroundSyncWork to use explicit session creation/destruction pattern instead of reusing existing sessions
- Simplified UnrollButtonStateMachine by removing the intermediate AboutToAttachWindow state
- Updated copyright year to 2026 and changed comment style to block comments
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| BackgroundSyncWork.kt | Refactored to create and destroy dedicated session instead of reusing first available session |
| UnrollButtonStateMachine.kt | Removed AboutToAttachWindow state, updated copyright to 2026, and changed to block comment style |
| InputBarDelegate.kt | Updated state machine handler to remove AboutToAttachWindow case and added new setUnrollWindowToAttach helper function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Found one issue which blocks the keyboard view.
|
I can't reproduce this, either ascii mode on nor off. Would you like to checkout to the commit before this PR then try again? |
|
The latest commit(9ee65a3) in the triage.mp4 |
|
@Bambooin Fixed. |
Bambooin
left a comment
There was a problem hiding this comment.
Confirmed, the issue is gone.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of this pull request
A few of refactors that I want to do recently.
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info