Skip to content

Misc Refactors#1922

Merged
WhiredPlanck merged 2 commits intoosfans:developfrom
WhiredPlanck:misc
Feb 4, 2026
Merged

Misc Refactors#1922
WhiredPlanck merged 2 commits intoosfans:developfrom
WhiredPlanck:misc

Conversation

@WhiredPlanck
Copy link
Collaborator

@WhiredPlanck WhiredPlanck commented Jan 31, 2026

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of this pull request

A few of refactors that I want to do recently.

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs several refactorings across the codebase, focusing on session management and state machine simplification.

Changes:

  • Modified BackgroundSyncWork to use explicit session creation/destruction pattern instead of reusing existing sessions
  • Simplified UnrollButtonStateMachine by removing the intermediate AboutToAttachWindow state
  • Updated copyright year to 2026 and changed comment style to block comments

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
BackgroundSyncWork.kt Refactored to create and destroy dedicated session instead of reusing first available session
UnrollButtonStateMachine.kt Removed AboutToAttachWindow state, updated copyright to 2026, and changed to block comment style
InputBarDelegate.kt Updated state machine handler to remove AboutToAttachWindow case and added new setUnrollWindowToAttach helper function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Bambooin
Copy link
Collaborator

Bambooin commented Feb 1, 2026

Found one issue which blocks the keyboard view.

  1. Open Firefox
  2. Input 'a'
  3. The keyboard is missing.

@WhiredPlanck
Copy link
Collaborator Author

WhiredPlanck commented Feb 1, 2026

Found one issue which blocks the keyboard view.

1. Open Firefox

2. Input 'a'

3. The keyboard is missing.

I can't reproduce this, either ascii mode on nor off. Would you like to checkout to the commit before this PR then try again?

@Bambooin
Copy link
Collaborator

Bambooin commented Feb 2, 2026

The latest commit(9ee65a3) in the develop branch is fine, and the issue is introduced in this patch.

triage.mp4

@WhiredPlanck
Copy link
Collaborator Author

@Bambooin Fixed.

Copy link
Collaborator

@Bambooin Bambooin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, the issue is gone.

@WhiredPlanck WhiredPlanck merged commit 1044be2 into osfans:develop Feb 4, 2026
3 checks passed
@WhiredPlanck WhiredPlanck deleted the misc branch February 4, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants