Fix circular imports between is800_2007.py Common.py#414
Draft
Zehen-249 wants to merge 2 commits intoosdag-admin:devfrom
Draft
Fix circular imports between is800_2007.py Common.py#414Zehen-249 wants to merge 2 commits intoosdag-admin:devfrom
Zehen-249 wants to merge 2 commits intoosdag-admin:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Common.pywas importingfrom .utils.common.component import *but was never used
This unnecessary import introduced a circular dependency between Common.py and component.py.
When Common.py was imported, it tried to load component.py.
component.py, in turn, imports from Common.py.
This created a circular import loop, which caused runtime errors during execution (e.g., when running tension_bolted_test.py).
this script was used to check the variables, methods and classes being used from component.py in Common.py
can be used in future for resolving any other circular import!!!