Pyplot fetaure of BMD and SFD in Flexural Module#390
Pyplot fetaure of BMD and SFD in Flexural Module#390harshgondal wants to merge 1 commit intoosdag-admin:devfrom
Conversation
AjinkyaDahale
left a comment
AjinkyaDahale
left a comment
There was a problem hiding this comment.
Some comments based on cursory look. The image change is critical.
src/ResourceFiles/images/ss_beam.png
Outdated
There was a problem hiding this comment.
This file cannot be accepted. It has a watermark and we are not certain about the license it has.
There was a problem hiding this comment.
Please squash both commits such that the image is not in the history. Also, note that you made additional changes, which should have been mentioned in the git message.
There was a problem hiding this comment.
I also notice that this file is in the wrong path. It should be in src/osdag/data/.../images/.
src/osdag/Common.py
Outdated
| KEY_BEARING_LENGTH = 'Bearing.Length' | ||
| Simply_Supported_img = str(files("osdag.data.ResourceFiles.images").joinpath("ss_beam.png")) | ||
| Cantilever_img = str(files("osdag.data.ResourceFiles.images").joinpath("c_beam.png")) | ||
| Cantilever_img = str(files("osdag.data.ResourceFiles.images").joinpath("c_beam.jpeg")) |
There was a problem hiding this comment.
Just as a comment: We probably do not want to have JPEGs. Ideally use SVG or a high resolution PNG.
| t9b = ("sf_plot_button", "", 'BUTTON', sf_button, True, "") | ||
| options_list.append(t9b) | ||
|
|
||
| # t_support = (KEY_SUPPORT, "Support Type", TYPE_COMBOBOX, ["Simply Supported", "Cantilever"], True, "") |
There was a problem hiding this comment.
If this code should stay here commented, add an additional comment as to why. Otherwise delete it.
| fName = str('./ResourceFiles/images/3d.png') | ||
| file_extension = fName.split(".")[-1] | ||
|
|
||
| # if file_extension == 'png': |
There was a problem hiding this comment.
Same as previous comment: add reason or delete commented code.
There was a problem hiding this comment.
The commented code was there in the source code, due to line change i think it is being reflected
src/osdag/gui/ui_template.py
Outdated
| ui.setupUi(MainWindow) | ||
| MainWindow.show() | ||
| sys.exit(app.exec_()) | ||
| sys.exit(app.exec_()) No newline at end of file |
There was a problem hiding this comment.
End file with newline.
…beam jpeg image to png
harshgondal
force-pushed
the
pyplot_bmd_and_sfd
branch
from
47ef36f to
9cd4642
Compare
|
Rebased all the commits, Added new ss_beam image, changed c_beam jpeg image to png, deleted commented code, fixed ss_beam path |
2 participants
Added Pyplot Feature of BMD and SFD in Flexural Module.
Harsh Gondal, Summer Fellowship